Bug #19374

Facet definitions are not idempotent

Added by Shimon Shtein 9 months ago. Updated 3 months ago.

Status:Closed
Priority:Normal
Assigned To:Shimon Shtein
Category:Plugins-Engines
Target version:Team Ivan Iteration 14
Difficulty: Bugzilla link:1445150
Found in release: Pull request:https://github.com/theforeman/foreman/pull/4484
Story points-
Velocity based estimate-
Release1.16.0Release relationshipAuto

Description

https://github.com/theforeman/foreman/blob/develop/app/models/concerns/facets/managed_host_extensions.rb#L51 uses alias_method_chain, that will create an endless call loop on second call.

Right now the only found affected scenario is call to Host#my_facet within migration.

Associated revisions

Revision 3be4ca4c
Added by Shimon Shtein 9 months ago

Fixes #19374 - added check to fix double facet registration

History

#1 Updated by Shimon Shtein 9 months ago

  • Bugzilla link set to 1445150

#2 Updated by The Foreman Bot 9 months ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4484 added

#3 Updated by Shimon Shtein 9 months ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Ivan Necas 8 months ago

  • Target version set to Team Ivan Iteration 14

#5 Updated by Marek Hulán 3 months ago

  • Release set to 1.16.0

Also available in: Atom PDF