Project

General

Profile

Actions
Copy link

Bug #19374

closed

Facet definitions are not idempotent

Added by Shimon Shtein over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Shimon Shtein
Category:
Plugin integration
Target version:
1.16.0
Difficulty:
Triaged:
Bugzilla link:
1445150
Pull request:
https://github.com/theforeman/foreman/pull/4484
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

https://github.com/theforeman/foreman/blob/develop/app/models/concerns/facets/managed_host_extensions.rb#L51 uses alias_method_chain, that will create an endless call loop on second call.

Right now the only found affected scenario is call to Host#my_facet within migration.

Actions
Copy link
 #1

Updated by Shimon Shtein over 7 years ago

  • Bugzilla link set to 1445150
Actions
Copy link
 #2

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4484 added
Actions
Copy link
 #3

Updated by Shimon Shtein over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link
 #4

Updated by Ivan Necas over 7 years ago

  • Target version set to 1.13.1
Actions
Copy link
 #5

Updated by Marek Hulán about 7 years ago

  • Translation missing: en.field_release set to 240
Actions
Copy link

Also available in: Atom PDF