Project

General

Profile

Feature #11250

Remove uniqueness check from network address validator in subnet.rb

Added by larry campbell almost 4 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
Network
Target version:
Difficulty:
trivial
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

I have a use case where we have a 20-bit block of IP addresses (4,096) that we cannot further subnet. The router is maintained by another organization, and we already have hundreds of devices using this network, mostly statically assigned. We currently block off ranges in a spreadsheet for each customer, and they maintain their own IP Addresses.

We now want to implement a Foreman server to manage the IP addressing, and would like to limit the range of available IPs for each customer.

This is a simple alternative to #10949

The proposed change is this:

edit: /usr/share/foreman/app/models/subnet.rb

Change

validates :network, :uniqueness => true,
                    :format => {:with => Net::Validations::IP_REGEXP}

to

validates :network, :format => {:with => Net::Validations::IP_REGEXP}


Related issues

Related to Foreman - Feature #10949: Create a new object called "ip range" to allow for more than one assignable ip address rangesNew2015-06-29
Related to Foreman - Bug #15508: Network address uniqueness enforced, duplicates should be possibleClosed2016-06-23

Associated revisions

Revision 3bd9a898 (diff)
Added by larry campbell almost 4 years ago

fixes #11250 - Remove uniqueness check from subnet network addresses

History

#2 Updated by Dominic Cleal almost 4 years ago

  • Category set to Network
  • Status changed from New to Ready For Testing
  • Assignee set to larry campbell
  • Pull request https://github.com/theforeman/foreman/pull/2585 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 4 years ago

  • Related to Feature #10949: Create a new object called "ip range" to allow for more than one assignable ip address ranges added

#4 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

#5 Updated by larry campbell almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal almost 3 years ago

  • Related to Bug #15508: Network address uniqueness enforced, duplicates should be possible added

Also available in: Atom PDF