Refactor #11449: Don't use therubyracer anymore - Foreman

Actions

Copy link

Refactor #11449

closed

Don't use therubyracer anymore

Added by Anonymous over 9 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Low

Assignee:

Category:

Packaging

Target version:

1.10.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2648

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

therubyracer has a longstanding history of problems on non-Linux and non-x86 platforms. It is used via the execjs gem, while execjs itself does support multiple engines and will select itself the one that's best from the available ones. GitLab went through all this and uses node.js now, which means the node.js package must be installed for all execjs related tasks.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Dominic Cleal over 9 years ago

I'd probably like to support both (via bundler groups?) as using therubyracer is easiest for our RPM packaging, since it's already provided by the ruby193 SCL. Alternatively, there's a node010 SCL which may do.

Actions

Copy link

Updated by The Foreman Bot over 9 years ago

Status changed from Assigned to Ready For Testing
Pull request https://github.com/theforeman/foreman/pull/2648 added
Pull request deleted ()

Actions

Copy link

Updated by Dominic Cleal over 9 years ago

Translation missing: en.field_release set to 63

I guess you're making a further change to the Debian packages for this? If you could update contribute.md as well on the website it'd be useful, thanks.

Actions

Copy link

Updated by Dominic Cleal over 9 years ago

Status changed from Ready For Testing to Closed
% Done changed from 0 to 100

https://github.com/theforeman/foreman-packaging/pull/799 is the corresponding change to Debian Jessie and Ubuntu Trusty packages. Everything else remains on therubyracer for now.

Actions

Copy link