Project

General

Profile

Refactor #11449

Don't use therubyracer anymore

Added by Michael Moll about 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
Packaging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

therubyracer has a longstanding history of problems on non-Linux and non-x86 platforms. It is used via the execjs gem, while execjs itself does support multiple engines and will select itself the one that's best from the available ones. GitLab went through all this and uses node.js now, which means the node.js package must be installed for all execjs related tasks.


Related issues

Related to Foreman - Refactor #16198: Remove therubyracer supportClosed2016-08-19
Blocks Packaging - Feature #14809: Build RPMs for Fedora 24Closed2016-04-26

Associated revisions

Revision 60a26f57 (diff)
Added by Michael Moll almost 4 years ago

refs #11449 - move therubyracer to its own bundler group

Revision 36ccf1b3 (diff)
Added by Dominic Cleal almost 4 years ago

refs #11449 - package therubyracer bundler group

therubyracer's easily available via RPMs, so continue using this for
assets compilation.

Revision 364b162d (diff)
Added by Michael Moll almost 4 years ago

refs #11449 - mention therubyracer bundler group

Revision da06a857
Added by Dominic Cleal almost 4 years ago

Merge pull request #427 from mmoll/therubyracer

refs #11449 - mention therubyracer bundler group

History

#1 Updated by Dominic Cleal about 4 years ago

I'd probably like to support both (via bundler groups?) as using therubyracer is easiest for our RPM packaging, since it's already provided by the ruby193 SCL. Alternatively, there's a node010 SCL which may do.

#2 Updated by The Foreman Bot almost 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2648 added
  • Pull request deleted ()

#3 Updated by Dominic Cleal almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 63

I guess you're making a further change to the Debian packages for this? If you could update contribute.md as well on the website it'd be useful, thanks.

#4 Updated by Dominic Cleal almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

https://github.com/theforeman/foreman-packaging/pull/799 is the corresponding change to Debian Jessie and Ubuntu Trusty packages. Everything else remains on therubyracer for now.

#5 Updated by Dominic Cleal over 3 years ago

#6 Updated by Dominic Cleal about 3 years ago

Also available in: Atom PDF