Project

General

Profile

Refactor #11452

Support rest-client 1.8

Added by Michael Moll almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Hammer core
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Also see https://github.com/Apipie/apipie-bindings/issues/27

I'm unsure if a direct dependency to rest-client is really needed, as apipie-bindings is doing all the work.


Related issues

Related to Hammer CLI - Refactor #11280: Revert Ruby 1.8 specificsClosed2015-08-04

Associated revisions

Revision dcd08154 (diff)
Added by Michael Moll almost 4 years ago

refs #11452 - bump required apipie-bindings version

Revision 3649cf1e (diff)
Added by Michael Moll almost 4 years ago

refs #11452 - delete direct dependencies

Revision 60a9f79f
Added by Martin Bacovsky almost 4 years ago

Merge pull request #180 from mmoll/apipie_0014

refs #11452 - bump required apipie-bindings version

Revision 83a9d407
Added by Martin Bacovsky almost 4 years ago

Merge pull request #193 from mmoll/apipie_0014

refs #11452 - delete direct dependencies

History

#1 Updated by Michael Moll almost 4 years ago

#2 Updated by Tomáš Strachota almost 4 years ago

I think that we can drop the line from gemspec now. It's there from historical reasons when we needed to add upper limit to pin rest-client down to a ruby 1.8 supported version without releasing new apipie-bindings.

#3 Updated by Michael Moll almost 4 years ago

As apipie-params specifies '< 1.8.0', but 1.7.x already has verify_ssl on by default this would trigger unexpected behaviour from the user's point of view, so let's wait for apipie-params to get everything sorted out and remove the direct dependency then.

#4 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/180 added
  • Pull request deleted ()

#5 Updated by Michael Moll almost 4 years ago

  • Assignee set to Michael Moll

https://github.com/theforeman/hammer-cli/pull/180 and https://github.com/theforeman/hammer-cli-foreman/pull/193 together should solve this issue (and after merging these, ideally a new gem release would be done).

#6 Updated by Michael Moll almost 4 years ago

  • Status changed from Ready For Testing to Closed

This is done in current master branches.

Also available in: Atom PDF