Refactor #11452
closed
Support rest-client 1.8
Description
Also see https://github.com/Apipie/apipie-bindings/issues/27
I'm unsure if a direct dependency to rest-client is really needed, as apipie-bindings is doing all the work.
Updated by Anonymous over 8 years ago
- Related to Refactor #11280: Revert Ruby 1.8 specifics added
Updated by Tomáš Strachota over 8 years ago
I think that we can drop the line from gemspec now. It's there from historical reasons when we needed to add upper limit to pin rest-client down to a ruby 1.8 supported version without releasing new apipie-bindings.
Updated by Anonymous over 8 years ago
As apipie-params specifies '< 1.8.0', but 1.7.x already has verify_ssl on by default this would trigger unexpected behaviour from the user's point of view, so let's wait for apipie-params to get everything sorted out and remove the direct dependency then.
Updated by The Foreman Bot over 8 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/hammer-cli/pull/180 added
- Pull request deleted (
)
Updated by Anonymous over 8 years ago
- Assignee set to Anonymous
https://github.com/theforeman/hammer-cli/pull/180 and https://github.com/theforeman/hammer-cli-foreman/pull/193 together should solve this issue (and after merging these, ideally a new gem release would be done).
Updated by Anonymous over 8 years ago
- Status changed from Ready For Testing to Closed
This is done in current master branches.