Project

General

Profile

Bug #11863

Rewrite except_hidden user scope for Rails 4 compatibility

Added by Daniel Lobato Garcia almost 4 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Rails
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

As it is written right now it needs a `.references(:users)` at the end in order to work. We can rewrite the query to be compatible with Rails 4 and Rails 3 at the same time.

Associated revisions

Revision 638cb73b (diff)
Added by Daniel Lobato Garcia almost 4 years ago

Fixes #11863 - Rewrite except_hidden user scope for Rails 4 compatibility

As it is written right now it needs a `.references(:users)` at the end
in order to work. We can rewrite the query to be compatible with Rails 4
and Rails 3 at the same time.

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/2734 added
  • Pull request deleted ()

#2 Updated by Dominic Cleal almost 4 years ago

  • Category set to Rails
  • Assignee set to Daniel Lobato Garcia
  • Legacy Backlogs Release (now unused) set to 63

#3 Updated by Daniel Lobato Garcia almost 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF