Bug #12393: Overriding the parameter default value doent adds 1 to the 'Number of Values' count. - Foreman

Actions

Copy link

Bug #12393

closed

Overriding the parameter default value doent adds 1 to the 'Number of Values' count.

Added by Jitendra Yejare about 9 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Low

Assignee:

Tomer Brisker

Category:

Web Interface

Target version:

1.11.0

Difficulty:

Triaged:

Bugzilla link:

1277952

Pull request:

https://github.com/theforeman/foreman/pull/3179

Fixed in Releases:

Found in Releases:

Nightly

Red Hat JIRA:

Description

Description of problem:
Overriding the parameter default value doent adds 1 to the 'Number of Values' count in parameters table in Config -> Smart Class Parameter page.

Version-Release number of selected component (if applicable):

How reproducible:
Always

Steps to Reproduce:
1. Override smart class parameter, set the default value.
2. Don't check 'puppet default value' checkbox.
3. See the 'Number Of Values' column for that parameter in Config -> Smart Class Parameters.

Actual results:
The count doesn't adds 1 to the 'Number of Values' for that parameter.

Expected results:
The count for 'Number of Values' should be increased by 1.

Actions

Copy link

Updated by Dominic Cleal about 9 years ago

Status changed from New to Feedback
Translation missing: en.field_release deleted (71)

Please don't set the release field.

Setting the default value is not creating an override, that's the section at the bottom of the form with specific matchers. This appears to be correct behaviour to me.

Actions

Copy link

Updated by Jitendra Yejare almost 9 years ago

Dominic Cleal wrote:

Please don't set the release field.

Setting the default value is not creating an override, that's the section at the bottom of the form with specific matchers. This appears to be correct behaviour to me.

But the column says the 'number of values' the parameter has and by giving default value which is atleast one value. And so I believe this needs to be fixed.
It will also help to identify that What are the parameters whose only default value has been overrided from table itself.

Actions

Copy link

Updated by Dominic Cleal almost 9 years ago

Status changed from Feedback to New
Assignee deleted (~~Tomer Brisker~~)
Priority changed from Normal to Low

It'd be better to call it the number of overrides since it's a counter, and if you need some way to indicate the presence of a default value, to indicate it another way.

Actions

Copy link