Bug #12712: No searchable link for "Owner" in host properties in non-english languages - Foreman

Bug #12712

No searchable link for "Owner" in host properties in non-english languages

Added by René Kaak over 7 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Tomer Brisker

Category:

Inventory

Target version:

Difficulty:

trivial

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/2963, https://github.com/theforeman/foreman/pull/7315, https://github.com/theforeman/foreman/pull/2965

Fixed in Releases:

1.24.1, 2.0.0

Found in Releases:

1.9.2

Red Hat JIRA:

Description

If the language isnt english the link in host properties doenst work. This comes from hosts_helper.rb in line 263. Is there any reason for the if-else? It filters for the word "User" which obviously only works for english.

I've attached a screenshot of the code and my workaround.

hosts_helper_bug.PNG	View hosts_helper_bug.PNG	8.14 KB	bug or intened?	René Kaak, 12/07/2015 01:42 AM
hosts_helper_fix.PNG	View hosts_helper_fix.PNG	10.6 KB	my personal workaround	René Kaak, 12/07/2015 01:42 AM

Associated revisions

Revision 9fdf33b8 (diff)
Added by Tomer Brisker about 3 years ago

Fixes #12712 - Fix owner link from host info page

The link only displays if the locale is set to English.

History

#1 Updated by Dominic Cleal over 7 years ago

Category set to Web Interface
Difficulty set to trivial

The owner_type will only ever be in English, so it should actually check for if host.owner_type == "User" as it's a DB column.

The second part of the conditional is used when a host is owned by a user group rather than a user, so it doesn't link to the individual user (it could actually link to a search for the group).

If you'd like to get this fixed, please do send the fix via a pull request (see http://theforeman.org/contribute.html).

#2 Updated by René Kaak over 7 years ago

The problem with my workaround is that it leads to a 500 error if the Owner is actually a usergroup. Need to find a way to fix this behaviour.. What is the search-context for usergroup? Trying to figure something out and will report back as soon as I understood some of the helpers better..

#3 Updated by Dominic Cleal over 7 years ago

Yeah, that's why I think the conditional needs fixing instead, because a usergroup object won't have the ".login" that a user does.

It looks like you could use a search like this for hosts owned by a user group: owner_type = Usergroup and owner_id = #{host.owner.id} (instead of user.login = ...).