Project

General

Profile

Bug #12827

Allow non isolated engines to add overrides to filters search path

Added by Marek Hulán over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Plugins-Engines
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

FilterHelperOverrides helper hardcodes deconstantize call, we should add detection for '::' and use it only if it's present, otherwise engines that are not isolated in own namespace (e.g. RemoteExecution) can't add their own autocompletion search overrides.

see the code for more details https://github.com/theforeman/foreman/blob/develop/app/helpers/filters_helper_overrides.rb#L13


Related issues

Related to Foreman - Feature #5753: Allow customisation of autocomplete_search path for resources in filter create/editClosed2014-05-02

Associated revisions

Revision ab0cc0a1 (diff)
Added by Marek Hulán over 3 years ago

Fixes #12827 - deconstantize resource only when needed

Revision 2486d7a4 (diff)
Added by Marek Hulán over 3 years ago

Fixes #12827 - deconstantize resource only when needed

(cherry picked from commit ab0cc0a1023a27d720da6c8f6e6e87c5164a858b)

History

#1 Updated by The Foreman Bot over 3 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Marek Hulán
  • Pull request https://github.com/theforeman/foreman/pull/2977 added

#2 Updated by Marek Hulán over 3 years ago

  • Related to Feature #5753: Allow customisation of autocomplete_search path for resources in filter create/edit added

#3 Updated by Dominic Cleal over 3 years ago

  • Legacy Backlogs Release (now unused) set to 104

#4 Updated by Marek Hulán over 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF