Refactor #13409
closedRemove maintain_test_schema! Rails initializer
Description
The config/initializers/0_maintain_test_schema.rb initializer added in #7230 can potentially be removed with some further fixes.
It exists to initialise the test database before the main Rails app and models are initialised, fixing a couple of bugs where loading the model requires the table to already be available. If the table isn't available then validators etc. aren't set up correctly and tests may fail. Removing the initialiser and the test DB, then running rake test
shows the issue. More info in #12873.
#13039 fixed one issue, but I think two further fixes are required:
1) validates_lengths_from_database needs to avoid reading DB information to set up its validators. https://github.com/rubiety/validates_lengths_from_database/pull/12 fixes this.
2) Our own validate_inclusion_in_families validator should not check for the attribute's existence - this check can probably be removed.
Updated by Dominic Cleal over 8 years ago
- Related to Feature #7230: Upgrade Ruby on Rails to 4.1 added
Updated by Dominic Cleal over 8 years ago
- Related to Refactor #13039: Remove DB queries from class of UnattendedController added
Updated by Dominic Cleal over 8 years ago
- Related to Feature #12873: Update Rails to 4.1.latest added
Updated by Dominic Cleal over 8 years ago
- Blocked by Bug #13574: Plugins with Setting subclasses raise super: no superclass method `load_defaults' error added
Updated by Dominic Cleal over 8 years ago
- Status changed from New to Assigned
- Assignee set to Dominic Cleal
Updated by The Foreman Bot over 8 years ago
- Status changed from Assigned to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/3182 added
Updated by Dominic Cleal over 8 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset f20c2a1abb049b57524fd5cd1e0a9177e9b04fad.
Updated by Dominic Cleal over 8 years ago
- Translation missing: en.field_release set to 71