Project

General

Profile

Actions

Bug #13427

closed

Progname not defined for SYSLOG logger

Added by Lukas Zapletal about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
High
Category:
Core
Target version:
Difficulty:
trivial
Triaged:
Fixed in Releases:
Found in Releases:

Description

According to Ruby API (http://ruby-doc.org/stdlib-2.1.0/libdoc/logger/rdoc/Logger.html#method-i-add) if both message and block are missing, progname should be treated as the message. The code in log decorator (buffer) has a bug that was working incorrectly. This shows up if there is SYSLOG logger configured and an error occurs:

/usr/share/foreman-proxy/lib/proxy/log_buffer/decorator.rb:19:in `add': undefined method `progname' for #<Syslog::Logger:0x0000000204a8b0> (NoMethodError)
    from /usr/share/foreman-proxy/lib/proxy/log_buffer/decorator.rb:50:in `error'
    from /usr/share/foreman-proxy/lib/launcher.rb:135:in `rescue in launch'
    from /usr/share/foreman-proxy/lib/launcher.rb:110:in `launch'
    from bin/smart-proxy:6:in `<main>'
Actions #1

Updated by The Foreman Bot about 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/smart-proxy/pull/370 added
Actions #2

Updated by Lukas Zapletal about 8 years ago

  • translation missing: en.field_release set to 71

I need this to be included in the 1.11 release, discovery image does not work without this patch. Thanks!

Actions #3

Updated by Anonymous about 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Lukas Zapletal about 8 years ago

  • Bugzilla link set to 1313860
Actions

Also available in: Atom PDF