Project

General

Profile

Bug #13939

API v1 hosts rabl references deprecated puppet_status call

Added by Dominic Cleal about 4 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
API
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

The API v1 hosts views use the puppet_status attribute, which is a deprecated getter from #10782, where only the v2 API was fixed to use the new version.

test/functional/api/v1/hosts_controller_test.rb prints:

DEPRECATION WARNING: You are using a deprecated behavior, it will be removed in version 1.13, Host#puppet_status has been deprecated, you should use configuration_status. (called from app_views_api_v_hosts_create_json_rabl__1200163205771380870_129174860 at /home/dcleal/code/foreman/foreman/app/views/api/v1/hosts/create.json.rabl:3)

Related issues

Related to Foreman - Feature #10782: Add global status for hostsClosed2015-06-11
Related to Foreman - Bug #13941: Core tests should not print API deprecation warningsClosed2016-02-29
Blocks Foreman - Refactor #13845: Remove 1.13 deprecationsClosed2016-02-23

Associated revisions

Revision ecc7b31f (diff)
Added by Dominic Cleal about 4 years ago

fixes #13939 - call non-deprecated status method from API rabl

Revision b079b71a (diff)
Added by Dominic Cleal almost 4 years ago

fixes #13939 - call non-deprecated status method from API rabl

(cherry picked from commit ecc7b31f8eb48ffd055b739776f8de4f8824bbe4)

History

#1 Updated by Dominic Cleal about 4 years ago

#2 Updated by The Foreman Bot about 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3249 added

#3 Updated by Dominic Cleal about 4 years ago

#4 Updated by Dominic Cleal about 4 years ago

  • Related to Bug #13941: Core tests should not print API deprecation warnings added

#5 Updated by Dominic Cleal about 4 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#6 Updated by Dominic Cleal about 4 years ago

  • Legacy Backlogs Release (now unused) set to 141

Also available in: Atom PDF