Bug #142
closed
RRD graph URL should not get forced to HTTP
Description
The URLs generated for the RRD graphs should use whatever protocol (HTTP/HTTPS) the page they were generated from is using, rather than getting forced to HTTP. This patch does that by just leaving the protocol portion of the URL off entirely.
Files
Updated by Ohad Levy over 14 years ago
- Status changed from New to Feedback
- Assignee changed from Ohad Levy to Frank Sweetser
this patch will not work when the rrd's are stored on another host than the host running foreman.
I'm not sure it makes so much sense to keep on supporting the rrd graphs, as it is so much easier for us just to plot them our self.
do you consider the rrd graphs as something that requires SSL? - as I assume you must have a vhost for supporting kickstart anyway...
Updated by Frank Sweetser over 14 years ago
Ohad Levy wrote:
this patch will not work when the rrd's are stored on another host than the host running foreman.
That's true, I didn't consider that configuration. I guess you could either put the host.pm_fqdn value back in, or remove the leading / and let the user set the hostname (and, if required, protocol) as part of :rrd_report_url.
I'm not sure it makes so much sense to keep on supporting the rrd graphs, as it is so much easier for us just to plot them our self.
That would certainly make things simpler.
do you consider the rrd graphs as something that requires SSL? - as I assume you must have a vhost for supporting kickstart anyway...
In my setup, yeah, I'd prefer to keep them SSL. I basically have two vhosts - one on 80 for things that can't be secured (kickstart and the like), and another one on 443 that apache is setup to require authentication for.
Updated by Ohad Levy over 14 years ago
now that there are host report graphs, can I reject this ?
Updated by Frank Sweetser over 14 years ago
Fine by me - moving the graphs into foreman itself completely solves the issue for me. Thanks!