Project

General

Profile

Bug #15077

Error HTML tags are shown

Added by Daniel Lobato Garcia about 7 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Daniel Lobato Garcia
Category:
Web Interface
Target version:
1.11.3
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/3532
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

On some custom errors we show, the alert_header helper is escaping the HTML tags we put on the alert title.

http://imgur.com/cm6l5ZW

Obviously these shouldn't be escaped.

Associated revisions

Revision 0300fadf (diff)
Added by Daniel Lobato Garcia about 7 years ago

Fixes #15077 - Error HTML tags are shown

On some custom errors we show, the alert_header helper is escaping the
HTML tags we put on the alert title.

http://imgur.com/cm6l5ZW

Obviously these shouldn't be escaped. Fix is as simple as marking the
string that puts the tags as html_safe

Revision 90e90fc6 (diff)
Added by Daniel Lobato Garcia almost 7 years ago

Fixes #15077 - Error HTML tags are shown

On some custom errors we show, the alert_header helper is escaping the
HTML tags we put on the alert title.

http://imgur.com/cm6l5ZW

Obviously these shouldn't be escaped. Fix is as simple as marking the
string that puts the tags as html_safe

(cherry picked from commit 0300fadf46da1526fe428a2cdb7183b24b13605b)

History

#1 Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/3532 added

#2 Updated by Daniel Lobato Garcia about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal about 7 years ago

  • Legacy Backlogs Release (now unused) set to 159

Also available in: Atom PDF