Feature #1552
closedPuppet proxy should support $confdir in modulepath when looking for environments/classes
Description
This is related to issue:1387. For those of use who followed the PuppetLabs blog (http://puppetlabs.com/blog/git-workflow-and-puppet-environments/) literally:
[main] server = puppet.example.com environment = production confdir = /etc/puppet [master] environment = production manifest = $confdir/environments/$environment/manifests/site.pp modulepath = $confdir/environments/$environment/modules [agent] report = true show_diff = true environment = production
The smart-proxy puppet component is returning an empty list of environments. As far as I can tell, the solution here can be as simple as looking at the modulepath value (in the dynamic environments block in lib/proxy/puppet/environment.rb) and, if that value contains "$confdir" and conf[:main][:confdir] is not nil, making the replacement.
I'm going to try and submit a patch for this later this week, but be warned, I'll be flipping through Learning Ruby as I do it.
Updated by Jason Antman over 12 years ago
Not exactly tested, but I have code for this that works in my environment:
https://github.com/jantman/smart-proxy/commit/95314b5cee6e93380efb7d64fbe50511f194f031
and a pull request:
https://github.com/theforeman/smart-proxy/pull/14
Updated by Jason Antman over 12 years ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset 2d232cffb4c90a27c0a1dc5a00d8fd733428f146.