Project

General

Profile

Actions

Refactor #15621

open

Change role builtin attribute to boolean

Added by Himanshu Prakash over 7 years ago. Updated almost 7 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Users, Roles and Permissions
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

Description of problem:
On cloning an user role, builtin parameter is set to null, causing the role to be treat as 'builtin' (unable to remove it) despite the fact, that API reports builtin: no

Version-Release number of selected component (if applicable):
6.2.0 beta GA17.0

How reproducible:
always

Steps to Reproduce:
1. navigate to Administer -> Roles
2. choose/create one of the roles which are not set as 'builtin' (in UI they are clickable)
3. clone them

Actual results:
Newly created role displayed as builtin despite the fact that `hammer role info` reports on it as 'builtin: no'.

listing the roles using API (curl -k https://<sat6>/api/v2/roles) shows, that the 'builtin' parameter is set to null.

Expected results:
'builtin' parameter defaults to 'false'


Related issues 2 (0 open2 closed)

Related to Foreman - Bug #15108: Cloned role has no builtin valueClosedMarek Hulán05/20/2016Actions
Related to Foreman - Bug #16828: Cloned roles should have `builtin` value 0ClosedSwapnil Abnave10/07/2016Actions
Actions #1

Updated by Dominic Cleal over 7 years ago

  • Related to Bug #15108: Cloned role has no builtin value added
Actions #2

Updated by Dominic Cleal over 7 years ago

This was reported already at #15108, and has been fixed in Foreman 1.12.0.

Actions #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3630 added
Actions #4

Updated by Marek Hulán over 7 years ago

  • Subject changed from WebUI - Cloned roles saved with nil value for builtin attribute to Change role builtin attribute to boolean
  • Category set to Users, Roles and Permissions

The original bug was solved as part of other change, meanwhile a PR for this issue was opened changing the builtin flag to boolean which long term seems as a good move so I'm changing the subject of this issue to reflect the PR.

Actions #5

Updated by Dominic Cleal almost 7 years ago

  • Related to Bug #16828: Cloned roles should have `builtin` value 0 added
Actions #6

Updated by Dominic Cleal almost 7 years ago

  • Tracker changed from Bug to Refactor
  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/3630)

PR closed due to inactivity.

Actions

Also available in: Atom PDF