Project

General

Profile

Bug #15694

upgrade_check does not correctly determine active tasks

Added by Brad Buckingham almost 3 years ago. Updated 11 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Jake Callahan
Category:
Upgrades
Target version:
Katello 3.2.0
Difficulty:
trivial
Triaged:
Bugzilla link:
1315269
Pull request:
https://github.com/Katello/katello/pull/6188
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

This redmine is being opened based upon a downstream finding with katello:upgrade_check.

The issue raised is:

The script currently checks of the number of running tasks is greater than 1. Since the query already excludes the candlepin listen event, the number of tasks acceptable should be 0. As a result, the script will pass incorrectly.

[root@rhsm-qe-1 ~]# foreman-rake katello:upgrade_check
This script makes no modifications and can be re-run multiple times for the most up to date results.
Checking upgradeability...

Checking for running tasks...
[PASS] - There are 1 active tasks.

Associated revisions

Revision d12e6e67 (diff)
Added by Jacob Callahan almost 3 years ago

Fixes #15694 - Change the number of accepted failed tasks to 0. (#6188)

Since the query already excludes the candlepin listen event, the
number of tasks acceptable should be 0.
As a result, the script will pass incorrectly.
Fixes #15694.

History

#1 Updated by The Foreman Bot almost 3 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6188 added

#2 Updated by Jake Callahan almost 3 years ago

  • Assignee set to Jake Callahan

#3 Updated by Jacob Callahan almost 3 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Justin Sherrill almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 162
  • Difficulty set to trivial

Also available in: Atom PDF