Project

General

Profile

Bug #16186

User shouldn't be allowed to add same package in content-view filter repeatedly

Added by John Mitsch over 2 years ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Content Views
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=981639
Description of problem:
User shouldn't be allowed to add same package in content-view filter repeatedly, especially when user choose 'All version'.

Version-Release number of selected component (if applicable):
katello-glue-elasticsearch-1.4.2-1.git.761.9817788.el6.noarch
katello-qpid-broker-key-pair-1.0-1.noarch
katello-cli-common-1.4.2-1.git.98.3567fd4.el6.noarch
katello-qpid-client-key-pair-1.0-1.noarch
signo-katello-0.0.9-1.el6.noarch
katello-glue-candlepin-1.4.2-1.git.761.9817788.el6.noarch
katello-1.4.2-1.git.761.9817788.el6.noarch
katello-repos-1.4.2-1.el6.noarch
katello-common-1.4.2-1.git.761.9817788.el6.noarch
katello-all-1.4.2-1.git.761.9817788.el6.noarch
katello-selinux-1.4.3-1.git.4.99dc194.el6.noarch
katello-candlepin-cert-key-pair-1.0-1.noarch
katello-cli-1.4.2-1.git.98.3567fd4.el6.noarch
katello-certs-tools-1.4.2-1.el6.noarch
katello-configure-1.4.3-1.git.65.63e692c.el6.noarch
katello-glue-pulp-1.4.2-1.git.761.9817788.el6.noarch

How reproducible:
always

Steps to Reproduce:
1. create a content-view definition
2. Create a package filter
3. include/exclude the same package repeatedly

Actual results:
User can add same package in cv filter repeatedly

Expected results:
shouldn't be allowed to add same package, when user selects 'All Version'

Additional info:

Associated revisions

Revision a43dc492 (diff)
Added by John Mitsch over 2 years ago

Fixes #16186 - Validate uniqueness on package filter rules (#6275)

To test - create a content view package filter and try to add
the same exact rule twice. You should get an error message explaining
that this rule has already been added on the second rule.

It is also worth testing that this won't block any normal usage of
filter rule creation.

History

#1 Updated by John Mitsch over 2 years ago

  • Assignee set to John Mitsch
  • Target version set to 123

#2 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6275 added

#3 Updated by John Mitsch over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#4 Updated by Justin Sherrill over 2 years ago

  • Legacy Backlogs Release (now unused) set to 162

Also available in: Atom PDF