Bug #16657: No validation for Discovery Rule name - Discovery - Foreman

Custom queries

All issues closed in the last 3 weeks
Discovery by votes
Easy and Trivial Issues
Good first issues - Foreman core
Mine
My issues closed in the last 3 weeks
Untriaged and opened in the past two weeks

Actions

Copy link

Bug #16657

closed

No validation for Discovery Rule name

Added by Swapnil Abnave about 8 years ago. Updated about 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Swapnil Abnave

Category:

Discovery plugin

Difficulty:

trivial

Triaged:

Bugzilla link:

1378486

Pull request:

https://github.com/theforeman/foreman_discovery/pull/302

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Description of problem:
Discovery Rule with name that is longer than 255 characters should not be created.

Actual results:
Discovery rule is created successfully

Expected results:
Error message ("is too long (maximum is 255 characters)") should be displayed

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Swapnil Abnave about 8 years ago

`discovery_rules` table description from discovery_plugin version 5.0.0.9

                                                          Table "public.discovery_rules" 
    Column    |            Type             |                          Modifiers                           | Storage  | Stats target | Description 
--------------+-----------------------------+--------------------------------------------------------------+----------+--------------+-------------
 id           | integer                     | not null default nextval('discovery_rules_id_seq'::regclass) | plain    |              | 
 name         | character varying(255)      |                                                              | extended |              | 
 search       | character varying(255)      |                                                              | extended |              | 
 hostgroup_id | integer                     | not null                                                     | plain    |              | 
 hostname     | character varying(255)      | default ''::character varying                                | extended |              | 
 max_count    | integer                     | default 0                                                    | plain    |              | 
 priority     | integer                     | default 0                                                    | plain    |              | 
 enabled      | boolean                     | not null default true                                        | plain    |              | 
 created_at   | timestamp without time zone |                                                              | plain    |              | 
 updated_at   | timestamp without time zone |                                                              | plain    |              | 
Indexes:
    "discovery_rules_pkey" PRIMARY KEY, btree (id)
Has OIDs: no

Latest table description for `discovery_rules`

katello=# \d+ discovery_rules
                                                          Table "public.discovery_rules" 
    Column    |            Type             |                          Modifiers                           | Storage  | Stats target | Description 
--------------+-----------------------------+--------------------------------------------------------------+----------+--------------+-------------
 id           | integer                     | not null default nextval('discovery_rules_id_seq'::regclass) | plain    |              | 
 name         | character varying           |                                                              | extended |              | 
 search       | character varying           |                                                              | extended |              | 
 hostgroup_id | integer                     | not null                                                     | plain    |              | 
 hostname     | character varying           | default ''::character varying                                | extended |              | 
 max_count    | integer                     | default 0                                                    | plain    |              | 
 priority     | integer                     | default 0                                                    | plain    |              | 
 enabled      | boolean                     | not null default true                                        | plain    |              | 
 created_at   | timestamp without time zone |                                                              | plain    |              | 
 updated_at   | timestamp without time zone |                                                              | plain    |              | 
Indexes:
    "discovery_rules_pkey" PRIMARY KEY, btree (id)
Has OIDs: no

As you can see the limits for columns name,search, hostname have been dropped in latest version. This is causing [validates_lengths_from_database[https://github.com/theforeman/foreman_discovery/blob/develop/app/models/discovery_rule.rb#L16]] to have no effect on length validation of model `DiscoveryRule`.

I am working on finding the reason the reason. But not able to get it, does anyone have idea about it ?

I searched in foreman, foreman_discovery plugins.. no luck.

Actions

Copy link