Project

General

Profile

Bug #1674

Error when modifying autosign.conf with commented line

Added by Joseph I almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
Puppet
Target version:
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

I received an error when trying to modify autosign.conf file with a commented line:

smart_proxy_autosign_url failed to generate from {:controller=>"SmartProxies::Autosign", :smart_proxy_id=>#<SmartProxy id: 1, name: "z03s-puppet", url: "https://z03s-puppet.example.com:8443", created_at: "2011-12-22 23:16:22", updated_at: "2011-12-24 16:15:19">, :auth_ation=>:destroy, :action=>"destroy", :id=>"#http://projects.puppetlabs.com/projects/1/wiki/Certificates_And_Security"}, expected: {:controller=>"SmartProxies::Autosign", :action=>"destroy"}, diff: {:smart_proxy_id=>#<SmartProxy id: 1, name: "z03s-puppet", url: "https://z03s-puppet.zebra.lan:8443", created_at: "2011-12-22 23:16:22", updated_at: "2011-12-24 16:15:19">, :auth_ation=>:destroy, :id=>"#http://projects.puppetlabs.com/projects/1/wiki/Certificates_And_Security"}

I would have expected foreman to ignore a commented out line.

I also received an error when trying to start a line that didn't begin with *:

Creating a line like "z03*.example.com" causes a similar error to the above.

autosign.conf_1 autosign.conf_1 39 Bytes hostname with * Joseph I, 06/28/2012 02:25 PM
autosign.conf_2 autosign.conf_2 36 Bytes network with *.* Joseph I, 06/28/2012 02:25 PM

Associated revisions

Revision 45455631 (diff)
Added by Jan Vansteenkiste over 6 years ago

fixes #1674: Ignore commented lines when reading all certificates in autosign and make sure the autosign file contains a EOL on the last line

History

#1 Updated by Ohad Levy almost 7 years ago

  • Project changed from Foreman to Smart Proxy

#2 Updated by Ohad Levy almost 7 years ago

can you provide a sample autosign file where this happens?

thanks

#3 Updated by Joseph I almost 7 years ago

I've just re-added z03*.zebra.lan, and have received the following error:

ActionView::TemplateError
smart_proxy_autosign_url failed to generate from {:controller=>"SmartProxies::Autosign", :smart_proxy_id=>#, :auth_ation=>:destroy, :action=>"destroy", :id=>"z03*.zebra.lan"}, expected: {:controller=>"SmartProxies::Autosign", :action=>"destroy"}, diff: {:smart_proxy_id=>#, :auth_ation=>:destroy, :id=>"z03*.zebra.lan"}
app/helpers/application_helper.rb:105:in `display_link_if_authorized'
app/views/smart_proxies/autosign/index.html.erb:15
app/views/smart_proxies/autosign/index.html.erb:11:in `each'
app/views/smart_proxies/autosign/index.html.erb:11

As requested I've attached an example autosign.conf:

WORKS:
.zebra.com
.zebra.lan

FAILS:
.zebra.com
.zebra.lan
z03*.zebra.lan

Note, removing the "offending" line from the command line, and then hitting refresh makes the error go away.

I've also tried adding a line with 192.168.*.*, to wild card with similar error messages.

#4 Updated by Adam Denning almost 7 years ago

Getting the same error here. It seems any use of a wildcard in auth.conf causes this error.

#5 Updated by Adam Denning almost 7 years ago

Sorry, I meant autosign.conf.

#6 Updated by Ohad Levy over 6 years ago

  • Category set to Puppet
  • Target version set to 1.1

#8 Updated by Jan Vansteenkiste over 6 years ago

  • Status changed from New to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF