Project

General

Profile

Actions

Refactor #16990

closed

Break apart AccessPermissionTest for easier plugin reuse

Added by Justin Sherrill almost 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Tests
Target version:
Difficulty:
easy
Triaged:
Fixed in Releases:
Found in Releases:

Description

Right now if a plugin wants to implement a similar test to the AccessPermissionsTest, it has to redefine all the constants here:

https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/access_permissions_test.rb#L14

if there are any routes added without a namespace (such as adding a new action to the hosts api). If a test tries to require that file, the test is actually executed and if there are additional items that need to be white listed, those will fail.

Actions #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/3950 added
Actions #2

Updated by Justin Sherrill almost 8 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #3

Updated by Dominic Cleal almost 8 years ago

  • Tracker changed from Bug to Refactor
  • Translation missing: en.field_release set to 189
Actions

Also available in: Atom PDF