Project

General

Profile

Feature #17145

Candlepin 2.0: Add in rollback support for failed manifest imports and refreshes

Added by David Davis almost 3 years ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Candlepin
Target version:
Katello Backlog
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:

Description

Before removing the old orchestration code, we had a way to rollback failed imports. See my PR here:

https://github.com/Katello/katello/pull/6414/files#diff-17c58a600ab07af9fd58f9c4ccb66be4L217

Dynflow didn't have this yet but there is a PR open to add support for rolling back actions:

https://github.com/Dynflow/dynflow/pull/194

Have the Owner::Import action rollback and call del_owner_import in Provider.

Related issues

Related to Katello - Feature #17027: CP 2.0: Phase 1: Enhance manifest import/refresh to support new candlepin async APIsNew2016-10-19

History

#1 Updated by David Davis almost 3 years ago

  • Related to Feature #17027: CP 2.0: Phase 1: Enhance manifest import/refresh to support new candlepin async APIs added

#2 Updated by Eric Helms almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 114

#3 Updated by David Davis almost 3 years ago

I started working on this but there's a snag. The existing code checks for a length of 1 for imports:

https://git.io/vXRfa

But here's what I see for imports. It seems to contain all attempts so it's rarely going to have a length of 1:

https://gist.github.com/daviddavis/4650f5de122c45d65f54031c34613c10

Here's my code which is a WIP. It reproduces the existing [broken] behavior in Dynflow:

https://github.com/daviddavis/katello/commit/fd4d08cb3fba6c121ac6e9d66db9b018c599487e

#4 Updated by Brad Buckingham almost 3 years ago

  • Target version changed from 133 to 140

#5 Updated by Brad Buckingham almost 3 years ago

  • Target version changed from 140 to 147

#6 Updated by Brad Buckingham almost 3 years ago

  • Target version changed from 147 to 151

#7 Updated by David Davis almost 3 years ago

  • Assignee deleted (David Davis)

#8 Updated by Brad Buckingham almost 3 years ago

  • Target version changed from 151 to 157

#9 Updated by Brad Buckingham almost 3 years ago

  • Target version changed from 157 to 160

Also available in: Atom PDF