foreman-debug: script says it was successful even when it obv. wasn't.
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1226017
Description of problem:
When something disrupts an upload of a foreman debug file, script still says it is successful, even when it isn't.
Version-Release number of selected component (if applicable):
snap 6 RHEL7
Steps to Reproduce:
1. foreman-debug -g -v -a -d /tmp/test
2. view results
A debug directory has been created: /tmp/test
You may want to upload the tarball to our public server via rsync. There is a
write only directory (readable only by Foreman core developers) for that. Note
the rsync transmission is UNENCRYPTED:
rsync /tmp/test.tar.xz rsync://theforeman.org/debug-incoming
Do you want to do this now? [y/N] y
rsync: link_stat "/tmp/test.tar.xz" failed: No such file or directory (2)
rsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1052) [sender=3.0.9]
The tarball has been uploaded, please contact us on mailing list or IRC.
If there is a failure in send, it should not says "The tarball has been uploaded".