Actions
Refactor #17880
closedDNS CNAME parameters methods are swapped
Difficulty:
trivial
Triaged:
Pull request:
Description
All DNS methods uses fqdn parameters as the target of the action and the second argument as the attribute that will be set to that target, e.g.
modules/dns_common/dns_common.rb
def a_record_conflicts(fqdn, ip)
...
end
def create_a_record(fqdn, ip)
...
end
def ptr_record_conflicts(fqdn, ip)
...
end
CNAME methods does the opposite, using attribute(fqdn alias) as the first argument and target(fqdn) as a second argument
modules/dns_common/dns_common.rb
def create_cname_record(fqdn, value)
...
end
def cname_record_conflicts(fqdn, target)
...
end
fqdn here actually means the alias we want to attribute to target
CNAME implementation is only used in dnscmd provider and I imagine that just a few make use of it.
Those which use this API would not have their aliases been set to their hosts.
Probably the provider would raise an error saying the fqdn is been use by an existing entry or the CNAME doesn't exist.
Actions