Project

General

Profile

Actions
Copy link

Refactor #17939

closed

Refactor Classification object to reduce its complaexity

Added by Shimon Shtein over 8 years ago. Updated over 6 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
Shimon Shtein
Category:
-
Target version:
-
Difficulty:
Triaged:
No
Bugzilla link:
Pull request:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

It's already done as part of https://github.com/theforeman/foreman/pull/3701, but I want to extract the Classification objects modification from there, and make it a standalone PR.

Main files:
ValuesHashQuery: query object that is responsible to return values hash for a given set of keys
Classification concern: A concern that adds two scopes (values_hash, inherited_values) that are implemented as calls to the ValuesHashQuery object.
ClassificationResult: Class that encapsulates rendering of values for a given key. Contains an option to show unrendered values too.

Actions
Copy link
 #1

Updated by The Foreman Bot over 8 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4163 added
Actions
Copy link
 #2

Updated by Tomer Brisker almost 7 years ago

  • Target version deleted (1.10.3)
  • Triaged set to No
Actions
Copy link
 #3

Updated by The Foreman Bot over 6 years ago

  • Status changed from Ready For Testing to New
  • Pull request deleted (https://github.com/theforeman/foreman/pull/4163)
Actions
Copy link
 #4

Updated by Shimon Shtein over 6 years ago

  • Status changed from New to Closed
Actions
Copy link
 #5

Updated by Tomer Brisker over 6 years ago

  • Status changed from Closed to Rejected
Actions
Copy link

Also available in: Atom PDF