Project

General

Profile

Bug #17998

Only print LDAP bind status if available

Added by Daniel Lobato Garcia over 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Normal
Category:
Logging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The ldap logger tries to call payload[:bind].status but it might not be defined if the bind goes wrong.
This causes a 500 instead of logging the status of the bind. We should display payload[:bind] and only .status if it's available.

Associated revisions

Revision 7447d046 (diff)
Added by Daniel Lobato Garcia over 2 years ago

Fixes #17998 - Only print LDAP bind status if available

The ldap logger tries to call payload[:bind].status but it might not be
defined if the bind goes wrong in some LDAP sources.

This causes a 500 instead of logging the status of the bind. We should
only display payload[:bind].status if it's available.

Revision 1040ff65 (diff)
Added by Daniel Lobato Garcia over 2 years ago

Fixes #17998 - Only print LDAP bind status if available

The ldap logger tries to call payload[:bind].status but it might not be
defined if the bind goes wrong in some LDAP sources.

This causes a 500 instead of logging the status of the bind. We should
only display payload[:bind].status if it's available.

(cherry picked from commit 7447d046a09751a96bff0f1e857e85a7aa176396)

History

#1 Updated by The Foreman Bot over 2 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4167 added

#2 Updated by Anonymous over 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#3 Updated by Dominic Cleal over 2 years ago

  • Legacy Backlogs Release (now unused) set to 210

#4 Updated by Daniel Lobato Garcia over 2 years ago

  • Target version set to 169

#5 Updated by Brad Buckingham about 2 years ago

  • Target version deleted (169)

#6 Updated by Daniel Lobato Garcia about 2 years ago

  • Target version set to 1.11.0

Also available in: Atom PDF