Project

General

Profile

Actions

Bug #18210

closed

Libvirt provider fails to set DHCP nametag when record doesn't have name field

Added by Daniel Lobato Garcia almost 8 years ago. Updated almost 8 years ago.

Status:
Resolved
Priority:
Normal
Category:
DHCP
Target version:
-
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

To set the nametag we call record.name, which might not be available.
In such a case, record.name fails with

] pry(#<Proxy::DHCP::Libvirt::LibvirtDHCPNetwork>)> record.name
#NoMethodError: undefined method `name' for #<Proxy::DHCP::Lease:0x005654f2c66798>
#from (pry):5:in `del_dhcp_record'

and the entire deletion fails. It should not call .name if it's not there.


Related issues 1 (0 open1 closed)

Related to Smart Proxy - Bug #18070: When adding a new dhcp reservation, ip and mac addresses should be checked not only against existing reservations but leases as wellClosed01/13/2017Actions
Actions #1

Updated by The Foreman Bot almost 8 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/smart-proxy/pull/500 added
Actions #2

Updated by Anonymous almost 8 years ago

  • Related to Bug #18070: When adding a new dhcp reservation, ip and mac addresses should be checked not only against existing reservations but leases as well added
Actions #3

Updated by Daniel Lobato Garcia almost 8 years ago

  • Target version set to 169
Actions #4

Updated by Anonymous almost 8 years ago

  • Target version deleted (169)

Closing this issue, as #18070 has been merged.

Actions #5

Updated by Anonymous almost 8 years ago

  • Status changed from Ready For Testing to Resolved
Actions

Also available in: Atom PDF