Project

General

Profile

Actions

Bug #18345

closed

Better rescue from syntax error in template rendering

Added by Marek Hulán about 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Templates
Target version:
Fixed in Releases:
Found in Releases:

Description

In unsafe mode rendering, SyntaxError can be raised, which is normally not caught. In this specific case, we should be able to rescue even from syntax errors to avoid ugly error pages.

Also we should set proper context so we can get at least the number of line where the error occurred. This is possible only in unsafe mode but better than nothing.


Related issues 1 (1 open0 closed)

Related to Foreman - Bug #9695: Clearer template errors should be given during build reviewNew03/10/2015Actions
Actions #1

Updated by Marek Hulán about 7 years ago

  • Related to Bug #9695: Clearer template errors should be given during build review added
Actions #2

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4247 added
Actions #3

Updated by Marek Hulán about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions #4

Updated by Dominic Cleal about 7 years ago

  • translation missing: en.field_release set to 209
Actions #5

Updated by The Foreman Bot about 7 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4366 added
Actions

Also available in: Atom PDF