Project

General

Profile

Refactor #18500

Remove quiet_assets dependency, no longer maintained

Added by Dominic Cleal over 1 year ago. Updated 10 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Logging
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

The quiet_assets gem used in development (when the assets bundler group is installed) is no longer maintained and so doesn't support Rails 5, because it was merged into sprockets-rails 3.1.0.

sprockets-rails 3.1.0 has a quiet flag that implements the same functionality by wrapping the request in the #silence method on the application logger. Note that the #silence method is only a no-op implementation in the logging gem (https://github.com/TwP/logging/issues/11).


Related issues

Blocked by Foreman - Refactor #18512: Support sprockets-rails 3Closed2017-02-15

Associated revisions

Revision fbbab0d8 (diff)
Added by Michael Moll about 1 year ago

fixes #18500 - replace quiet_assets with sprockets-rails flag

  • fixes #18512 - support sprockets-rails 3.x

The app.assets environment is no longer always configured, and instead
is only configured when the regular Rails environment is loaded. Loading
only the 'assets' group initializers isn't sufficient.

Because the asset group initializers are no longer run, the plugin API
has been extended with `precompile_assets` and `automatic_assets` to
store and optionally generate a list of assets for that plugin. It
deprecates using an assets initializer, modifying SETTINGS and
`config.assets.precompile` to configure the plugin asset list.

  • fixes #18500 - replace quiet_assets with sprockets-rails flag

quiet_assets was merged into sprockets-rails 3.1+ and is no longer
maintained for Rails 5, so it can be removed. Min version hasn't been
increased as it only affects development log verbosity and isn't a hard
dependency. Older versions used in packages will work fine.

The logging gem deliberately doesn't implement the #silence method, so
this is wrapped to fully match the Rails API and make the feature work.

History

#1 Updated by Dominic Cleal over 1 year ago

#2 Updated by The Foreman Bot about 1 year ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/4542 added

#3 Updated by The Foreman Bot about 1 year ago

  • Pull request https://github.com/theforeman/foreman/pull/4646 added

#4 Updated by Michael Moll about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Marek Hulán about 1 year ago

  • Legacy Backlogs Release (now unused) set to 240
  • Pull request deleted (https://github.com/theforeman/foreman/pull/4542)

Also available in: Atom PDF