Actions
Refactor #19003
closed
Use ApplicationRecord instead of ActiveRecord::Base
Difficulty:
Triaged:
Description
Because Rails 5 will require apps to use ApplicationRecord and because this makes things easier for us to redirect orchestration log messages from sql to orch logger, we are making a change in core and introducing this class (#13772).
Most ActiveRecord::Base use must be replaced, specifically:
app/model/ - model classes
db/migrate/ - "fake" reopened classes otherwise TypeError: superclass mismatch for class XYZ
test/ - reopened classes otherwise TypeError: superclass mismatch for class XYZ
Such an example change can be seen in https://github.com/theforeman/foreman/pull/3729
Updated by Lukas Zapletal about 7 years ago
- Related to Bug #13772: The orchestration code uses SQL logger added
Updated by The Foreman Bot about 7 years ago
- Status changed from New to Ready For Testing
- Assignee set to Lukas Zapletal
- Pull request https://github.com/theforeman/foreman_discovery/pull/334 added
Updated by Anonymous almost 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset foreman_discovery|3c6f9bdca3a9942a9818557c9a291baddb3fff1d.
Updated by Anonymous almost 7 years ago
- Related to Bug #20051: foreman_discovery 9.1.0 is not compatible with Foreman 1.15.x added
Actions