Bug #13772
The orchestration code uses SQL logger
| Status: | Closed | ||
|---|---|---|---|
| Priority: | Normal | ||
| Assignee: |  Lukas Zapletal | ||
| Category: | Orchestration | ||
| Target version: | 1.16.0 | ||
| Difficulty: | Team Backlog: | ||
| Triaged: | Fixed in Releases: | ||
| Bugzilla link: | Found in Releases: | ||
| Pull request: | https://github.com/theforeman/foreman/pull/4454, https://github.com/theforeman/foreman/pull/3729 | ||
Description
It should have it's own logger. Ideally with using the hierarchy system,
that the Logging library provides, https://github.com/TwP/logging/blob/master/examples/hierarchies.rb
so that one could extract logging for the whole orchestration, or a part of it.
Related issues
Associated revisions
Fixes #13772 - orchestration now uses app logger
Refs #13772 - ensure ApplicationRecord is loaded soon enough
In `lib/core_extensions.rb` we define as `per_page` method, that gets
called by `will_paginate` at load time of the models. The issue is
we are using `Setting` model there, that inherits from the
`ApplicationRecord` but the `ApplicationRecord` is not loaded yet at
that time, which leads to Rails not knowings it's abstract class
and therefore expecting it to be a base for STI.
After this patch, we require the `ApplicationRecord` soon enough to make
sure it's present before using any other model.
History
#1
Updated by Lukas Zapletal about 2 years ago
- Related to Bug #14980: Unused_ip AJAX request fails: undefined method `from' for #<IPAM::Dhcp..> added
#2
Updated by The Foreman Bot almost 2 years ago
- Status changed from New to Ready For Testing
- Assignee set to Lukas Zapletal
- Pull request https://github.com/theforeman/foreman/pull/3729 added
#3
Updated by Daniel Lobato Garcia almost 2 years ago
- Target version set to 1.6.2
#4
Updated by Daniel Lobato Garcia almost 2 years ago
- Target version changed from 1.6.2 to 1.5.2
#5
Updated by Lukas Zapletal over 1 year ago
- Related to Refactor #19002: Use ApplicationRecord instead of ActiveRecord::Base added
#6
Updated by Lukas Zapletal over 1 year ago
- Related to Refactor #19003: Use ApplicationRecord instead of ActiveRecord::Base added
#7
Updated by Lukas Zapletal over 1 year ago
- Related to Tracker #15715: Rails 5.0 upgrade tasks added
#8
Updated by Lukas Zapletal over 1 year ago
The implementation uses ApplicationRecord - new feature of Rails 5. Associated tracking ticket.
#9
Updated by Dominic Cleal over 1 year ago
Lukas Zapletal wrote:
The implementation uses ApplicationRecord - new feature of Rails 5. Associated tracking ticket.
An abstract base class is nothing to do with Rails 5!
#10
Updated by Lukas Zapletal over 1 year ago
- Related to deleted (Tracker #15715: Rails 5.0 upgrade tasks)
#11
Updated by Lukas Zapletal over 1 year ago
Well it's now recommended by Rails 5, but if this makes you to type bangs, then I will unlink it. No biggie.
#12
Updated by Lukas Zapletal over 1 year ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 4deab2f313841e4283469ce9faafc0cdf1775720.
#13
Updated by The Foreman Bot over 1 year ago
- Pull request https://github.com/theforeman/foreman/pull/4454 added
#14
Updated by Ivan Necas about 1 year ago
- Related to Bug #19395: Failure when migrating database with foreman_remote_executino from scratch added
#15
Updated by Marek Hulán about 1 year ago
- Legacy Backlogs Release (now unused) set to 240