Project

General

Profile

Bug #19446

Incremental backup script in effect is performing full backup.

Added by Evgeni Golov almost 2 years ago. Updated 9 months ago.

Status:
Closed
Priority:
High
Category:
Backup & Restore
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1445989

Description of problem: Incremental backup script in effect is performing full backup.

One error similar to the following:

cp: cannot stat ‘*.snar’: No such file or directory

It seems that the below files are used to provide a diff. As they weren't being read, customer was getting a full backup instead of an incremental backup.

.config.snar
.mongo.snar
.postgres.snar
.pulp.snar

Adding the '.' to the command on line 131 fixed the problem:

`cp #{@options[:incremental]}/.*.snar .` if @options[:incremental]

Below is the difference between two files.

=================================================================
  1. diff u katello-backup katello-backup.new
    --
    katello-backup 2017-02-03 10:01:31.000000000 -0500
    +++ katello-backup.new 2017-04-25 09:56:54.162505948 -0400
    @ -128,7 +128,7 @
    `tar --selinux --create --gzip --file=config_files.tar.gz --listed-incremental=.config.snar #{CONFIGS.join(' ')}`
    puts "Done."

- `cp #{@options[:incremental]}/*.snar .` if @options[:incremental]
+ `cp #{@options[:incremental]}/.*.snar .` if @options[:incremental] =================================================================

if @options[:online]
backup_db_online

Version-Release number of selected component (if applicable):

How reproducible: Reproducible at customer's environment.

Steps to Reproduce: Take incremental backup using the below command.

  1. katello-backup /path/to/dir --incremental [PREVIOUS_BACKUP_DIR]

Actual results: Incremental backup script is performing full backup.

Expected results: It should perform incremental backup.

Additional info: Customer had provided the above solution which they expect to be included in future release or to fix the issue.

Associated revisions

Revision 744ea662 (diff)
Added by Christine Fouant almost 2 years ago

fixes #19446 - fixes incremental backup performing full backup

Revision 6dc945c1
Added by Mike McCune almost 2 years ago

Merge pull request #436 from cfouant/incrementalregression

fixes #19446 - fixes incremental backup performing full backup

History

#1 Updated by The Foreman Bot almost 2 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello-packaging/pull/436 added

#2 Updated by Justin Sherrill almost 2 years ago

  • Subject changed from Incremental backup script in effect is performing full backup. to Incremental backup script in effect is performing full backup.
  • Legacy Backlogs Release (now unused) set to 211

#3 Updated by Justin Sherrill almost 2 years ago

  • Legacy Backlogs Release (now unused) changed from 211 to 228

#4 Updated by Christine Fouant almost 2 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#5 Updated by Eric Helms almost 2 years ago

  • Legacy Backlogs Release (now unused) changed from 228 to 211

Also available in: Atom PDF