Refactor #19534: Excessive amount of log messages around db field encryption - Foreman

Refactor #19534

Excessive amount of log messages around db field encryption

Added by Lukas Zapletal almost 6 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Lukas Zapletal

Category:

Logging

Target version:

1.15.1

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4548, https://github.com/theforeman/foreman/pull/4529

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

Foreman logs tremendous amount of messages about db field encryption. Major issues: Every en/decryption is logged at info level:

Successfully decrypted field for XYZ

Every attempt to decrypt unencrypted field is reported via debug (annoying in dev mode):

String does not start with the prefix 'encrypted-' XYZ

We should not log success scenarios at all (maybe into TRACE level if we had one) and we need to decrease amount of logs for the other actions, like the annoying "String does not start" messasges.

Related issues

Associated revisions

Revision bed45946 (diff)
Added by Lukas Zapletal almost 6 years ago

Fixes #19534 - removed excessive encryptor logging

Revision 1da8bd42 (diff)
Added by Dominic Cleal almost 6 years ago

refs #19534 - check EncryptValue class variables are defined

bed4594 added class variables to record logging state, but failed to
check it was defined before accessing them, causing exceptions when
decryption failed. Tests added for this new behaviour.

Revision ad5b976d (diff)
Added by Lukas Zapletal almost 6 years ago

Fixes #19534 - removed excessive encryptor logging

(cherry picked from commit bed45946878572b854e64b54ca63a8b294cb53bf)

Revision bf1a55e3 (diff)
Added by Dominic Cleal almost 6 years ago

refs #19534 - check EncryptValue class variables are defined

bed4594 added class variables to record logging state, but failed to
check it was defined before accessing them, causing exceptions when
decryption failed. Tests added for this new behaviour.

(cherry picked from commit 1da8bd42a95c9e254ea28efbd1b409ac5ab3033e)