Bug #19730
Warning "not recommended to unlock this template" does not work
Description
After upgrade to Foreman 1.15 (dev setup) I don't see vendor set for core templates - it is nil. We need to make sure during migration that all core templates has vendor set to "Foreman" (and "Katello"), so the message is shown.
if template.vendor _("It is not recommended to unlock this template, as it is provided by %{vendor} and may be overwritten. Please consider cloning it instead.") % {:vendor => template.vendor} end
It is important to show this message for core templates, it's the main reason why we actually implemented template locking. Setting as 1.15 candidate.
Associated revisions
Fixes #19730 - Add vendor to provisioning templates
Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).
(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)
Fixes #19730 - Add vendor to provisioning templates
Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).
(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)
History
#1
Updated by Daniel Lobato Garcia almost 6 years ago
- Legacy Backlogs Release (now unused) changed from 248 to 266
#2
Updated by Daniel Lobato Garcia over 5 years ago
- Legacy Backlogs Release (now unused) changed from 266 to 276
#3
Updated by Daniel Lobato Garcia over 5 years ago
- Legacy Backlogs Release (now unused) changed from 276 to 287
#4
Updated by The Foreman Bot over 5 years ago
- Status changed from New to Ready For Testing
- Assignee set to Daniel Lobato Garcia
- Pull request https://github.com/theforeman/foreman/pull/4817 added
#5
Updated by Anonymous over 5 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset f646ff568c4a050baf50d726584447da28986669.
Fixes #19730 - Add vendor to provisioning templates
Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).