Project

General

Profile

Bug #19730

Warning "not recommended to unlock this template" does not work

Added by Lukas Zapletal over 1 year ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Category:
Templates
Target version:
Difficulty:
Triaged:
Bugzilla link:
Team Backlog:
Fixed in Releases:
Found in Releases:

Description

After upgrade to Foreman 1.15 (dev setup) I don't see vendor set for core templates - it is nil. We need to make sure during migration that all core templates has vendor set to "Foreman" (and "Katello"), so the message is shown.

        if template.vendor
          _("It is not recommended to unlock this template, as it is provided by %{vendor} and may be overwritten. Please consider cloning it instead.") %
            {:vendor => template.vendor}
        end

It is important to show this message for core templates, it's the main reason why we actually implemented template locking. Setting as 1.15 candidate.

Associated revisions

Revision f646ff56 (diff)
Added by Daniel Lobato Garcia about 1 year ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

Revision 2a616511 (diff)
Added by Daniel Lobato Garcia about 1 year ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)

Revision 20c2a0c8 (diff)
Added by Daniel Lobato Garcia about 1 year ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)

History

#1 Updated by Daniel Lobato Garcia over 1 year ago

  • Legacy Backlogs Release (now unused) changed from 248 to 266

#2 Updated by Daniel Lobato Garcia about 1 year ago

  • Legacy Backlogs Release (now unused) changed from 266 to 276

#3 Updated by Daniel Lobato Garcia about 1 year ago

  • Legacy Backlogs Release (now unused) changed from 276 to 287

#4 Updated by The Foreman Bot about 1 year ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4817 added

#5 Updated by Anonymous about 1 year ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

Also available in: Atom PDF