Bug #19730: Warning "not recommended to unlock this template" does not work - Foreman

Bug #19730

Warning "not recommended to unlock this template" does not work

Added by Lukas Zapletal almost 6 years ago. Updated over 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Daniel Lobato Garcia

Category:

Templates

Target version:

1.15.4

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/foreman/pull/4817

Fixed in Releases:

Found in Releases:

Red Hat JIRA:

Description

After upgrade to Foreman 1.15 (dev setup) I don't see vendor set for core templates - it is nil. We need to make sure during migration that all core templates has vendor set to "Foreman" (and "Katello"), so the message is shown.

        if template.vendor
          _("It is not recommended to unlock this template, as it is provided by %{vendor} and may be overwritten. Please consider cloning it instead.") %
            {:vendor => template.vendor}
        end

It is important to show this message for core templates, it's the main reason why we actually implemented template locking. Setting as 1.15 candidate.

Associated revisions

Revision f646ff56 (diff)
Added by Daniel Lobato Garcia over 5 years ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

Revision 2a616511 (diff)
Added by Daniel Lobato Garcia over 5 years ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)

Revision 20c2a0c8 (diff)
Added by Daniel Lobato Garcia over 5 years ago

Fixes #19730 - Add vendor to provisioning templates

Before unlocking a provisioning template, a warning is shown on the
screen. This warning should contain the vendor that provided the
template (normally Foreman or Katello).

(cherry picked from commit f646ff568c4a050baf50d726584447da28986669)