Project

General

Profile

Actions

Bug #19730

closed

Warning "not recommended to unlock this template" does not work

Added by Lukas Zapletal over 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Templates
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

After upgrade to Foreman 1.15 (dev setup) I don't see vendor set for core templates - it is nil. We need to make sure during migration that all core templates has vendor set to "Foreman" (and "Katello"), so the message is shown.

        if template.vendor
          _("It is not recommended to unlock this template, as it is provided by %{vendor} and may be overwritten. Please consider cloning it instead.") %
            {:vendor => template.vendor}
        end

It is important to show this message for core templates, it's the main reason why we actually implemented template locking. Setting as 1.15 candidate.

Actions #1

Updated by Daniel Lobato Garcia over 7 years ago

  • Translation missing: en.field_release changed from 248 to 266
Actions #2

Updated by Daniel Lobato Garcia over 7 years ago

  • Translation missing: en.field_release changed from 266 to 276
Actions #3

Updated by Daniel Lobato Garcia about 7 years ago

  • Translation missing: en.field_release changed from 276 to 287
Actions #4

Updated by The Foreman Bot about 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Daniel Lobato Garcia
  • Pull request https://github.com/theforeman/foreman/pull/4817 added
Actions #5

Updated by Anonymous about 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF