Project

General

Profile

Bug #20393

Foreman tasks table should be using index method instead of bulk_search

Added by Walden Raines almost 5 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web UI
Target version:
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Currently we are using the foreman tasks bulk search api in katello for our tasks tables. We should move to using the index method instead as it supports pagination.

katello_3.4.2_product_pager.png View katello_3.4.2_product_pager.png 2.3 KB Lachlan Simpson, 06/25/2017 11:06 PM
Katello 3.4.2 product pager

Related issues

Blocked by foreman-tasks - Bug #20933: Subtotal is being incorrectly set in tasks controller indexClosed

Associated revisions

Revision 51de0437 (diff)
Added by Dan Seethaler almost 5 years ago

Fixes #20393: Remove pagination when not used
This removes pagination on the bulk_search
tasks pages where it is no longer needed.
The bulk_search api only returns 10 results.

http://projects.theforeman.org/issues/20393

History

#4 Updated by Eric Helms almost 5 years ago

  • Legacy Backlogs Release (now unused) changed from 281 to 286

#5 Updated by Walden Raines almost 5 years ago

  • Category set to Web UI
  • Assignee changed from Walden Raines to Dan Seethaler
  • Target version set to 160

Here is some more information. The katello tasks page appears on many pages in the application. A couple of examples are Content Hosts -> tasks and Products -> tasks.

Basically we need to change this:

https://github.com/katello/katello/blob/master/engines/bastion_katello/app/assets/javascripts/bastion_katello/tasks/task.factory.js#L33

To use the index method here:

https://github.com/theforeman/foreman-tasks/blob/master/app/controllers/foreman_tasks/api/tasks_controller.rb#L110

We should be able to accomplish that by using "queryPaged" from the bastion resource:

https://github.com/katello/bastion/blob/master/app/assets/javascripts/bastion/utils/bastion-resource.factory.js#L16

#6 Updated by Walden Raines almost 5 years ago

  • Target version changed from 160 to 208

#7 Updated by Brad Buckingham almost 5 years ago

  • Target version changed from 208 to 213

#8 Updated by Eric Helms almost 5 years ago

  • Legacy Backlogs Release (now unused) changed from 286 to 295

#9 Updated by The Foreman Bot almost 5 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/6950 added

#10 Updated by Walden Raines almost 5 years ago

  • Blocked by Bug #20933: Subtotal is being incorrectly set in tasks controller index added

#11 Updated by Anonymous almost 5 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100

#12 Updated by The Foreman Bot almost 5 years ago

  • Pull request https://github.com/Katello/katello/pull/6949 added

Also available in: Atom PDF