Project

General

Profile

Actions
Copy link

Bug #20575

closed

Hammer prints wrong error when there's unauthorized request at the beginning of a sessions

Added by Tomáš Strachota over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Strachota
Category:
Hammer core
Target version:
hammer-cli-0.12.0
Difficulty:
Triaged:
Bugzilla link:
1481184
Pull request:
https://github.com/theforeman/hammer-cli-foreman/pull/323
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:
Red Hat JIRA:

Description

When a user is logged out, tries to start a new sessions and enters wrong credentials, hammer prints an error message as if there was an existing session.

Reproducer steps:
  1. Enable sessions in the config file for hammer
  2. hammer auth logout
  3. hammer -u admin -p wrong_pwd host list

Actual result:
Hammer prints:

Invalid username or password, continuing with session for ''

Expected result:

Invalid username or password

Actions
Copy link
 #1

Updated by Tomáš Strachota over 7 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Tomáš Strachota over 7 years ago

  • Bugzilla link set to 1481184
Actions
Copy link
 #3

Updated by The Foreman Bot over 7 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/323 added
Actions
Copy link
 #4

Updated by Marek Hulán over 7 years ago

  • Target version changed from 1.18.0-RC2 to 214
Actions
Copy link
 #5

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF