Project

General

Profile

Refactor #20957

Replace alias_method_chain with Module prepend

Added by Michael Moll over 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Michael Moll
Category:
Rails
Target version:
1.17.0
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/foreman/pull/4845
Fixed in Releases:
Found in Releases:

Related issues

Related to Boot disk - Bug #14797: Medium validation wrong with Katello and foreman_bootdiskClosed
Blocks Foreman - Tracker #15715: Rails 5.0 upgrade tasksResolved2016-07-18

Blocks Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed2017-09-16

Associated revisions

Revision 38964973 (diff)
Added by Dominic Cleal over 2 years ago

Fixes #20957 - Replace alias_method_chain with Module prepend

Deprecated in Rails 5.0 and will be removed in 5.1. Some instances of
classes overwriting existing methods can be handled with `super`, other
concerns or modules are changed to use prepend instead of include.

Note: no ActiveSupport::Concern support for prepends, so load class
methods the pure Ruby way.

History

#1 Updated by Michael Moll over 2 years ago

#2 Updated by The Foreman Bot over 2 years ago

  • Pull request https://github.com/theforeman/foreman/pull/4845 added

#3 Updated by Michael Moll over 2 years ago

#4 Updated by Ivan Necas over 2 years ago

  • Status changed from Ready For Testing to Closed

#5 Updated by Lukas Zapletal over 2 years ago

  • Related to Bug #14797: Medium validation wrong with Katello and foreman_bootdisk added

Also available in: Atom PDF