Project

General

Profile

Actions

Bug #21442

closed

Loading puppet class parameters is stuck when creating new host

Added by Shira Maximov over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Fixed in Releases:
Found in Releases:

Description

reproduce steps:
1. create new host
2. in the host subtab: choose Environment and Puppet Master
3. in puppet class subtab: add available class
4. in parameters subtab: Puppet Class Parameters should appear. instead, it's stuck

Actions #1

Updated by Tomer Brisker over 7 years ago

This is caused by a Rails 5 change in ActionView that skips blank data attributes [1] causing the JS code used to serialize the form [2] to send `undefined` instead of `null`.

[1] https://github.com/rails/rails/commit/aeee438bf120f44a4402250fa50ef530f3c830a8#diff-3d863df5229eeafadb6df53160605a5b
[2] https://github.com/theforeman/foreman/blob/develop/app/assets/javascripts/host_edit.js#L204

Actions #2

Updated by The Foreman Bot over 7 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Tomer Brisker
  • Pull request https://github.com/theforeman/foreman/pull/4939 added
Actions #3

Updated by Marek Hulán over 7 years ago

  • Translation missing: en.field_release set to 296
Actions #4

Updated by Anonymous over 7 years ago

  • Status changed from Ready For Testing to Closed
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF