Actions
Bug #21496
closedRoles not properly removing permissions
Difficulty:
Triaged:
Bugzilla link:
Pull request:
Description
def permission_records(permissions) collection = Permission.where(:name => permissions.flatten).all raise ::Foreman::PermissionMissingException.new(N_('some permissions were not found')) if collection.size != permissions.size collection end
In a call for the permissions_records method, the permissions were of the format ":view_tasks, :view_bookmarks" (https://github.com/theforeman/foreman/blob/develop/db/seeds.d/020-roles_list.rb#L38, https://github.com/theforeman/foreman/blob/develop/lib/seed_helper.rb#L92.)
This parameter caused the following stack trace
Foreman::PermissionMissingException: ERF73-2603 [Foreman::PermissionMissingException]: some permissions were not found /usr/share/foreman/app/models/role.rb:288:in `permission_records' /usr/share/foreman/app/models/role.rb:164:in `find_for_permission_removal' /usr/share/foreman/app/models/role.rb:205:in `remove_permissions!' /usr/share/foreman/lib/seed_helper.rb:80:in `block in update_role_permissions' /usr/share/foreman/app/models/role.rb:228:in `ignore_locking' /usr/share/foreman/lib/seed_helper.rb:72:in `update_role_permissions' /usr/share/foreman/lib/seed_helper.rb:53:in `create_role' /usr/share/foreman/db/seeds.d/03-roles.rb:9:in `block (3 levels) in <top (required)>' /usr/share/foreman/db/seeds.d/03-roles.rb:8:in `each' /usr/share/foreman/db/seeds.d/03-roles.rb:8:in `block (2 levels) in <top (required)>' /opt/theforeman/tfm/root/usr/share/gems/gems/audited-4.4.1/lib/audited/auditor.rb:283:in `without_auditing' /usr/share/foreman/db/seeds.d/03-roles.rb:4:in `block in <top (required)>' /opt/theforeman/tfm/root/usr/share/gems/gems/audited-4.4.1/lib/audited/auditor.rb:283:in `without_auditing' /usr/share/foreman/db/seeds.d/03-roles.rb:3:in `<top (required)>' /opt/rh/rh-ror42/root/usr/share/gems/gems/activesupport-4.2.6/lib/active_suppo
The reason for PermissionMissingException was that "collection.size != permissions.size" while it should technically be "collection.size != permissions.flatten.size"
Updated by The Foreman Bot almost 7 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman/pull/4957 added
Updated by Marek Hulán almost 7 years ago
- Translation missing: en.field_release set to 296
Updated by Marek Hulán almost 7 years ago
- Related to Bug #21342: Role needs to be updated if their permissions changed in new version added
Updated by Partha Aji almost 7 years ago
- Status changed from Ready For Testing to Closed
- % Done changed from 0 to 100
Applied in changeset 6a1f0e1adcea166c15785b05989a97462fb7ec9b.
Actions