Project

General

Profile

Bug #21623

hammer repository upload-content is successful even with incorrect product ID

Added by Andrew Kofink almost 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Repositories
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1434871

Description of problem:

When using hammer to upload a new package, it tells it is successful even if the product ID and repository combination is invalid

Version-Release number of selected component (if applicable):

How reproducible: Always

Steps to Reproduce:
  1. hammer repository upload-content --id 454 --product-id 54 --path CS_COLLECTD_CODE-2.1-1.x86_64.rpm
    Successfully uploaded file 'CS_COLLECTD_CODE-2.1-1.x86_64.rpm'.
  1. hammer repository info --id 454 --product-id 54
    ID: 454
    Name: R_Operations_Yum
    Label: R_Operations_Yum
    Organization: org1
    Red Hat Repository: no
    Content Type: yum
    URL:
    Publish Via HTTP: no
    Published At: https://usl10149341.am.hedani.net/pulp/repos/org1/ENG/CV_CSL3_1_0/custom/P_Operations/R_Operations_Yum/
    Relative Path: org1/ENG/CV_CSL3_1_0/custom/P_Operations/R_Operations_Yum
    Download Policy: immediate
    Product:
    ID: 40
    Name: P_Operations
    GPG Key:

Sync:
Status: Not Synced
Created: 2016/09/29 12:09:19
Updated: 2016/11/16 15:15:01
Content Counts:
Packages: 8
Package Groups: 0
Errata: 0

(NOTE product-id is 40 in this output)

Actual results: It says that the content is successfully uploaded

Expected results:
It should give a proper error message if product Id is incorrect

Additional info:

Associated revisions

Revision 3f04813d (diff)
Added by Andrew Kofink almost 4 years ago

Fixes #21623 - Validate repo upload options (#528)

History

#1 Updated by The Foreman Bot almost 4 years ago

  • Assignee set to Andrew Kofink
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/hammer-cli-katello/pull/528 added

#2 Updated by Anonymous almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#3 Updated by Justin Sherrill almost 4 years ago

  • Legacy Backlogs Release (now unused) set to 284
  • Subject changed from hammer repository upload-content is successful even with incorrect product ID to hammer repository upload-content is successful even with incorrect product ID

Also available in: Atom PDF