Project

General

Profile

Bug #21768

Support NIL values in searchable options

Added by Martin Bacovsky over 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Martin Bacovsky
Category:
Foreman commands (obsolete)
Target version:
-
Difficulty:
Triaged:
Bugzilla link:
Pull request:
https://github.com/theforeman/hammer-cli/pull/264, https://github.com/theforeman/hammer-cli-foreman/pull/346
Team Backlog:
Fixed in Releases:
Found in Releases:
In Kanboard:

Description

Currently setting the NIL (unset) values is supported only for common options. The searchable options won't resolve properly:

hammer host update --id 83 --domain NIL
Could not update the host:
  Error: domain not found

Requested result is the domain_id to be unset

Related issues

Related to Hammer CLI - Bug #17252: Unable to set empty parameter via hammerClosed2016-11-07
Related to Katello - Bug #22824: Resolving content_view_version_ids is brokenClosed2018-03-08
Related to Hammer CLI - Bug #22879: HammerCLIKatello::ContentViewPuppetModule::CreateCommand.get_identifier wrong numer of argumentsDuplicate2018-03-13

Associated revisions

Revision 4928d442 (diff)
Added by Martin Bacovsky over 4 years ago

Refs #21768 - Make option sources overridable

Revision c61d1365 (diff)
Added by Martin Bacovsky over 4 years ago

Fixes #21768 - Allow nil searchables

Adds ability to correctly resolve name params set to NIL.

For better coexistence with hammer defaults the logic
was moved to option sources which is now preferred place
for manipulation with options. As a result when options
or all_options is called anywhere in the code it should
return fully resolved options in final state.

History

#1 Updated by Martin Bacovsky over 4 years ago

  • Related to Bug #17252: Unable to set empty parameter via hammer added

#2 Updated by Martin Bacovsky over 4 years ago

  • Tracker changed from Feature to Bug

#3 Updated by Martin Bacovsky over 4 years ago

  • Target version set to 241
  • Assignee set to Martin Bacovsky
  • Status changed from New to Assigned

#4 Updated by The Foreman Bot over 4 years ago

  • Status changed from Assigned to Ready For Testing
  • Pull request https://github.com/theforeman/hammer-cli/pull/264 added

#5 Updated by The Foreman Bot over 4 years ago

  • Pull request https://github.com/theforeman/hammer-cli-foreman/pull/346 added

#6 Updated by Martin Bacovsky over 4 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#7 Updated by Andrew Kofink over 4 years ago

  • Related to Bug #22824: Resolving content_view_version_ids is broken added

#8 Updated by Ales Dujicek over 4 years ago

  • Related to Bug #22879: HammerCLIKatello::ContentViewPuppetModule::CreateCommand.get_identifier wrong numer of arguments added

Also available in: Atom PDF