Project

General

Profile

Bug #22055

bookmarks loading spinner might keep on spinning if there are no saved bookmarks

Added by Ohad Levy almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Difficulty:
Triaged:
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

while its not visible on the screen (unless you open the bookmarks dropdown) it should stop displaying the spinner once the API response was completed.

bookmark-spinner.png View bookmark-spinner.png 6.59 KB Ohad Levy, 12/21/2017 10:17 AM
Bookmark spinner

Related issues

Related to Foreman - Feature #20839: implement bookmark creation using reactClosed2017-09-04

Associated revisions

Revision 876df025 (diff)
Added by Ohad Levy almost 3 years ago

fixes #22055 - update bookmark loading status.

This PR both fixes the issue reported by not showing spinner if
there is an empty set of saved bookmarks (it shows None found)

It also adds missing tests cases for spinner, error and empty
result sets, and replaces the loader component from patternfly-react
Spinner component.

History

#1 Updated by Ohad Levy almost 3 years ago

  • Related to Feature #20839: implement bookmark creation using react added

#3 Updated by Ohad Levy almost 3 years ago

  • Description updated (diff)

#4 Updated by The Foreman Bot almost 3 years ago

  • Assignee set to Ohad Levy
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman/pull/5106 added

#5 Updated by Timo Goebel almost 3 years ago

  • Legacy Backlogs Release (now unused) set to 296

#6 Updated by Ohad Levy almost 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF