Project

General

Profile

Actions

Refactor #22083

closed

Rails 5.1: attribute_changed? inside model callbacks

Added by Timo Goebel almost 6 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Discovery plugin
Fixed in Releases:
Found in Releases:

Description

These deprecations should get fixed:

ActiveSupport::DeprecationException: DEPRECATION WARNING: The behavior of `attribute_changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_change_to_attribute?` instead. (called from update_notifications at /Users/f0218175/foremandev/foreman_discovery/app/models/host/managed_extensions.rb:71)

ActiveSupport::DeprecationException: DEPRECATION WARNING: The behavior of `attribute_changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_change_to_attribute?` instead. (called from delete_discovery_attribute_set at /Users/f0218175/foremandev/foreman_discovery/app/models/host/managed_extensions.rb:66)
/Users/f0218175/foremandev/foreman_discovery/app/models/host/managed_extensions.rb:66:in `delete_discovery_attribute_set'


Related issues 2 (0 open2 closed)

Related to Foreman - Tracker #20948: Rails 5.1 upgrade tasksClosed09/16/2017

Actions
Related to Foreman - Tracker #21834: Rails 5.2 upgrade tasksClosed

Actions
Actions #1

Updated by Timo Goebel almost 6 years ago

  • Related to Refactor #21959: Remove positional arguments for Rails 5.1 compatibility added
Actions #2

Updated by Anonymous almost 6 years ago

Actions #3

Updated by Anonymous almost 6 years ago

  • Related to deleted (Refactor #21959: Remove positional arguments for Rails 5.1 compatibility)
Actions #4

Updated by Anonymous almost 6 years ago

Actions #5

Updated by Anonymous almost 6 years ago

Personally I'd wait for Rails 5.2 support in core to really know, where changes are needed.

Actions #6

Updated by Anonymous over 5 years ago

  • Status changed from New to Ready For Testing
  • Assignee set to Anonymous

_discovery has an empty config/as_deprecation_whitelist.yaml in it's repo, now I'm also running into this...

Actions #7

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/400 added
Actions #8

Updated by Timo Goebel over 5 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/399 added
Actions #9

Updated by Anonymous over 5 years ago

  • Assignee changed from Anonymous to Timo Goebel
  • Pull request deleted (https://github.com/theforeman/foreman_discovery/pull/400)
Actions #10

Updated by The Foreman Bot over 5 years ago

  • Pull request https://github.com/theforeman/foreman_discovery/pull/401 added
Actions #11

Updated by Timo Goebel about 5 years ago

  • Status changed from Ready For Testing to Closed
Actions

Also available in: Atom PDF