Refactor #22083
closed
Rails 5.1: attribute_changed? inside model callbacks
Description
These deprecations should get fixed:
ActiveSupport::DeprecationException: DEPRECATION WARNING: The behavior of `attribute_changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_change_to_attribute?` instead. (called from update_notifications at /Users/f0218175/foremandev/foreman_discovery/app/models/host/managed_extensions.rb:71)
ActiveSupport::DeprecationException: DEPRECATION WARNING: The behavior of `attribute_changed?` inside of after callbacks will be changing in the next version of Rails. The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now). To maintain the current behavior, use `saved_change_to_attribute?` instead. (called from delete_discovery_attribute_set at /Users/f0218175/foremandev/foreman_discovery/app/models/host/managed_extensions.rb:66)
/Users/f0218175/foremandev/foreman_discovery/app/models/host/managed_extensions.rb:66:in `delete_discovery_attribute_set'
Updated by Timo Goebel over 7 years ago
- Related to Refactor #21959: Remove positional arguments for Rails 5.1 compatibility added
Updated by Anonymous over 7 years ago
- Related to deleted (Refactor #21959: Remove positional arguments for Rails 5.1 compatibility)
Updated by Anonymous over 7 years ago
- Status changed from New to Ready For Testing
- Assignee set to Anonymous
Updated by The Foreman Bot over 7 years ago
- Pull request https://github.com/theforeman/foreman_discovery/pull/400 added
Updated by Timo Goebel over 7 years ago
- Pull request https://github.com/theforeman/foreman_discovery/pull/399 added
Updated by Anonymous over 7 years ago
- Assignee changed from Anonymous to Timo Goebel
- Pull request deleted (
https://github.com/theforeman/foreman_discovery/pull/400)
Updated by The Foreman Bot over 7 years ago
- Pull request https://github.com/theforeman/foreman_discovery/pull/401 added