Project

General

Profile

Bug #24270

Enabled repo report saves cache even if remote server error occurs, resulting in invalid errata

Added by Andrew Kofink about 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Errata Management
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1594948

Description of problem:

The enabled-repos-report, which is run on every yum transaction, will save the report in a cache file so to not re-submit the same information multiple times. It appears that this cache gets saved regardless of whether the report upload was successful or not.

If an error occurs, the cache would be saved, and it would never re-attempt to upload the report unless something actually changed.

Version-Release number of selected component (if applicable):
3.4.z

How reproducible:
intermittent (with some difficulty).

Steps to Reproduce:
1. Enable/disable a repo on a client with sub-man repos
2. Cause the enabled-repos-report to fail somehow

Actual results:
Note that the cache file is updated: /var/cache/katello-agent/enabled_repos.json

Expected results:
Cache is not updated, report is resubmitted with next yum command.

Additional info:

Associated revisions

Revision 95a7de9c (diff)
Added by Andrew Kofink about 3 years ago

Fixes #24270: Handle server errors

Don't update the cache if the server fails to update

History

#1 Updated by Andrew Kofink about 3 years ago

  • Subject changed from Enabled repo report saves cache even if remote server error occurs, resulting in invalid errata to Enabled repo report saves cache even if remote server error occurs, resulting in invalid errata

This should go on 3.7, not necessarily GA.

#2 Updated by The Foreman Bot about 3 years ago

  • Assignee set to Andrew Kofink
  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello-host-tools/pull/68 added

#3 Updated by Andrew Kofink about 3 years ago

  • % Done changed from 0 to 100
  • Status changed from Ready For Testing to Closed

#4 Updated by Jonathon Turel about 3 years ago

  • Target version set to Katello 3.7.0

#5 Updated by Andrew Kofink about 3 years ago

  • Triaged changed from No to Yes

Also available in: Atom PDF