Project

General

Profile

Feature #24676

Moving Katello to Rails 5.2

Added by Ido Kanner over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

Making Katello Rails 5.2 ready (and Rails 5.1 compatible).


Related issues

Related to Foreman - Tracker #21834: Rails 5.2 upgrade tasksClosed

Associated revisions

Revision 1ff80cec (diff)
Added by Ido Kanner over 1 year ago

Fixes #24676 - Rails 5.2 compatibility (#7626)

  • Fixes #24676 - Rails 5.2 compatibility

IMPORTANT:

Since rails 5.2, _before_last_save and _was exists on different stages
of callback cycles the _was exists on "before_save", and
"_before_last_save" "after_save" here the following method is called
on both callback hooks, so it is validating both cases.

Additional important thing to know, is that "_was" changes it's value
after "save" was called, and it is pointing to the current value of
that field, so just using the "_was" will trigger it's own issues.

  • Remove unused methods in callbacks
  • Make method changes backward compatible with 5.1

History

#1 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing

#2 Updated by Andrew Kofink over 1 year ago

  • Triaged changed from No to Yes
  • Target version set to Katello 3.9.0

#3 Updated by Ivan Necas over 1 year ago

#4 Updated by Anonymous over 1 year ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF