Actions
Bug #25613
open
Template snapshot tests should use multiple OS families
Description
Currently, all snaps are generated using a RH host, so they don't correctly reflect real use case. https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/template_snapshot_service.rb#L25
Updated by Lukas Zapletal over 5 years ago
- Triaged changed from No to Yes
So what is exactly wrong with this? RH is the primary architectury for foreman, at least most devs use RH systems. Do you mean we should run them twice - once for Debian and once for RH system?
Updated by Tomer Brisker over 5 years ago
- Related to Bug #25567: Wrong provision method signature for RancherOS added
Updated by Tomer Brisker over 5 years ago
That we don't validate the templates work for the correct OS family - this was raised because #25567 was hit because the snapshots missed to catch the fact that rancherOS couldn't render templates at all, since the template snapshot for the rancheros templates was rendered using a rh host.
Updated by The Foreman Bot over 4 years ago
- Status changed from New to Ready For Testing
- Assignee set to Lukas Zapletal
- Pull request https://github.com/theforeman/foreman/pull/7140 added
Updated by Lukas Zapletal over 4 years ago
- Subject changed from template snapshots should use correct os family to Template snapshot tests should use multiple OS families
- Category deleted (
Tests) - Assignee deleted (
Lukas Zapletal)
And PXE loader as well.
Updated by The Foreman Bot about 4 years ago
- Status changed from Ready For Testing to New
- Pull request deleted (
https://github.com/theforeman/foreman/pull/7140)
Actions