Refactor #25839: Avoid storing puppetserver version related parameters in the answer file - Installer - Foreman

Actions

Copy link

Refactor #25839

closed

Avoid storing puppetserver version related parameters in the answer file

Added by Ewoud Kohl van Wijngaarden about 6 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Ewoud Kohl van Wijngaarden

Category:

Foreman modules

Target version:

Foreman - 1.21.0

Difficulty:

Triaged:

Bugzilla link:

Pull request:

https://github.com/theforeman/puppet-puppet/pull/668, https://github.com/theforeman/foreman-installer/pull/311, https://github.com/theforeman/foreman-installer/pull/313, https://github.com/theforeman/foreman-installer/pull/316

Fixed in Releases:

Foreman - 1.21.0

Found in Releases:

Red Hat JIRA:

Description

Currently we store some parameters in the answers file that relate to the puppetserver version. This is because we determine them in params.pp which means init.pp has them. The result is that when a user upgrades, their answers need to be reset. Katello has a hook to always do this, Foreman has nothing.

By defaulting to undef and moving the the determination into server.pp we can avoid this whole problem.