Project

General

Profile

Bug #25853

The suggestion to whitelist steps does not contain currently white-listed steps

Added by Martin Bacovsky about 2 years ago. Updated 4 months ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
-
Target version:
-
Difficulty:
Triaged:
Yes
Bugzilla link:
Fixed in Releases:
Found in Releases:

Description

When I run check with --whitelist <steps> and the check fails it suggest to whitelist the failing steps in case it is false positive. The suggestion does not include the steps it was run with.

$ foreman-maintain upgrade check --target-version 6.4.z --whitelist="check-epel-repository,repositories-validate,disk-performance" 
...
Check whether reports have correct associations:                      [OK]
--------------------------------------------------------------------------------
Check for duplicate Puppet class records:                             [OK]
--------------------------------------------------------------------------------
Validate availability of repositories:                                [SKIPPED]
--------------------------------------------------------------------------------
Scenario [Checks before upgrading to Satellite 6.4.z] failed.

The following steps ended up in failing state:

  [hammer-ping]
  [services-up]

The following steps ended up in warning state:

  [check-hotfix-installed]

Resolve the failed steps and rerun
the command. In case the failures are false positives,
use --whitelist="hammer-ping,services-up" 

Expected output:

Resolve the failed steps and rerun
the command. In case the failures are false positives,
use --whitelist="check-epel-repository,repositories-validate,disk-performance,hammer-ping,services-up" 

Associated revisions

Revision 2dd9f217 (diff)
Added by Suraj Patil 4 months ago

Fixes #25853 - Improved suggestion to whitelist steps

History

#1 Updated by The Foreman Bot over 1 year ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/theforeman/foreman_maintain/pull/258 added

#2 Updated by Kavita Gaikwad 6 months ago

  • Assignee set to Suraj Patil

#3 Updated by Suraj Patil 4 months ago

  • Status changed from Ready For Testing to Closed

Also available in: Atom PDF