Actions
Bug #25853
closedThe suggestion to whitelist steps does not contain currently white-listed steps
Difficulty:
Triaged:
Yes
Description
When I run check with --whitelist <steps> and the check fails it suggest to whitelist the failing steps in case it is false positive. The suggestion does not include the steps it was run with.
$ foreman-maintain upgrade check --target-version 6.4.z --whitelist="check-epel-repository,repositories-validate,disk-performance" ... Check whether reports have correct associations: [OK] -------------------------------------------------------------------------------- Check for duplicate Puppet class records: [OK] -------------------------------------------------------------------------------- Validate availability of repositories: [SKIPPED] -------------------------------------------------------------------------------- Scenario [Checks before upgrading to Satellite 6.4.z] failed. The following steps ended up in failing state: [hammer-ping] [services-up] The following steps ended up in warning state: [check-hotfix-installed] Resolve the failed steps and rerun the command. In case the failures are false positives, use --whitelist="hammer-ping,services-up"
Expected output:
Resolve the failed steps and rerun the command. In case the failures are false positives, use --whitelist="check-epel-repository,repositories-validate,disk-performance,hammer-ping,services-up"
Updated by The Foreman Bot almost 5 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/theforeman/foreman_maintain/pull/258 added
Updated by Suraj Patil over 3 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset foreman_maintain|2dd9f21747f2745cb928f5602360dad990d5a38a.
Actions