Bug #25980
closed[Container Admin] Changing repository of any type through web UI changes "Container Image Tags Filter" field value
Description
Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1649866
Docker tags whitelist (called "Container Image Tags Filter" in hammer, "Limit Sync Tags" in web UI) field is set in any repository edited through web UI. It seems that web UI always sets and sends that field and nothing in backend filters it out for non-docker repositories.
So far I wasn't able to discover any negative impact of that field set for non-docker repositories.
Version:
pulp-server-2.17.1-1.el7sat.noarch
katello-3.9.0-0.11.rc2.el7sat.noarch
foreman-1.20.0-0.17.RC2.el7sat.noarch
satellite-6.5.0-3.beta.el7sat.noarch
Steps to reproduce:
1. Create new product
2. Create new repository of type different than docker
3. Verify that docker_tags_whitelist key is not set for new repository (in hammer you should not see "Container Image Tags Filter", in API "docker_tags_whitelist" should be `null`)
4. Edit this repository using web UI (e.g. change name)
5. Repeat step 3
Actual results:
`hammer repository info --id <id>` will contain "Container Image Tags Filter" line
`curl -u admin:PASS -k https://localhost/katello/api/repositories/<id>` will return `"docker_tags_whitelist": []`
Expected results:
docker tags whitelist is not changed - it is still equal to `null` in API, line is not present in hammer
Additional info:
Changing repository using hammer does not affect docker_tags_whitelist field
Updated by The Foreman Bot about 6 years ago
- Status changed from New to Ready For Testing
- Pull request https://github.com/Katello/katello/pull/7962 added
Updated by Justin Sherrill almost 6 years ago
- Subject changed from [Container Admin] Changing repository of any type through web UI changes "Container Image Tags Filter" field value to [Container Admin] Changing repository of any type through web UI changes "Container Image Tags Filter" field value
- Target version set to Katello 3.12.0
Updated by Andrew Kofink almost 6 years ago
- Status changed from Ready For Testing to Closed
Applied in changeset katello|098bc257aef291e575d1035a47bf97f562189332.