Project

General

Custom queries

Profile

Actions
Copy link

Refactor #26011

closed

Change Dialog component to MessageDialog from patternfly

Added by Maria Agaphontzev over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Maria Agaphontzev
Category:
-
Target version:
Katello 3.12.0
Branch:
Difficulty:
Triaged:
Yes
Bugzilla link:
Pull request:
https://github.com/Katello/katello/pull/7970
Fixed in Releases:
Found in Releases:
Red Hat JIRA:

Description

Instead of moving the 'ConfirmDialog' and 'Dialog' from Katello's 'move_to_foreman' directory to foreman,
using MessageDialog component from patternfly.
Small design changes:

foreman Dialog:

Confirm delete:

Exit without saving:

Wrong data:

Confirm Edit:

patternflys MessageDialog:

Confirm delete:

Exit without saving:

Wrong data:

Confirm Edit:

Files

screenshot-192.168.121.233-2019.02.07-12-35-40.png View screenshot-192.168.121.233-2019.02.07-12-35-40.png 24.5 KB Maria Agaphontzev, 02/07/2019 01:22 PM
screenshot-192.168.121.233-2019.02.07-12-35-24.png View screenshot-192.168.121.233-2019.02.07-12-35-24.png 12.8 KB Maria Agaphontzev, 02/07/2019 01:23 PM
screenshot-192.168.121.233-2019.02.07-12-35-06.png View screenshot-192.168.121.233-2019.02.07-12-35-06.png 11 KB Maria Agaphontzev, 02/07/2019 01:23 PM
screenshot-192.168.121.233-2019.02.07-12-34-33.png View screenshot-192.168.121.233-2019.02.07-12-34-33.png 11.9 KB Maria Agaphontzev, 02/07/2019 01:23 PM
screenshot-192.168.121.233-2019.02.07-15-25-43.png View screenshot-192.168.121.233-2019.02.07-15-25-43.png 14.6 KB Maria Agaphontzev, 02/07/2019 01:25 PM
screenshot-192.168.121.233-2019.02.07-15-25-07.png View screenshot-192.168.121.233-2019.02.07-15-25-07.png 11.2 KB Maria Agaphontzev, 02/07/2019 01:25 PM
screenshot-192.168.121.233-2019.02.07-15-25-19.png View screenshot-192.168.121.233-2019.02.07-15-25-19.png 12.8 KB Maria Agaphontzev, 02/07/2019 01:25 PM
screenshot-192.168.121.233-2019.02.07-15-24-42.png View screenshot-192.168.121.233-2019.02.07-15-24-42.png 19.4 KB Maria Agaphontzev, 02/07/2019 01:26 PM
#1

Updated by The Foreman Bot over 6 years ago

  • Status changed from New to Ready For Testing
  • Pull request https://github.com/Katello/katello/pull/7970 added
#2

Updated by Christine Fouant about 6 years ago

  • Target version set to Katello 3.12.0
  • Triaged changed from No to Yes
#3

Updated by Anonymous about 6 years ago

  • Status changed from Ready For Testing to Closed
Actions
Copy link

Also available in: Atom PDF